Skip to content

[Misc] Move jsontree to utils #22622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2025
Merged

[Misc] Move jsontree to utils #22622

merged 1 commit into from
Aug 11, 2025

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Aug 11, 2025 •
edited by github-actions bot
Loading

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Reduce the number of modules in the root vLLM namespace

Test Plan

Test Result

(Optional) Documentation Update

@DarkLight1337
[Misc] Move jsontree to utils
7fb0c14 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 requested a review from Isotr0py August 11, 2025 07:28
@DarkLight1337 DarkLight1337 requested a review from ywang96 as a code owner August 11, 2025 07:28
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 11, 2025
@mergify mergify bot added the multi-modality Related to multi-modality (#4194) label Aug 11, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Aug 11, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the codebase by moving the jsontree module into the vllm.utils package to improve code organization. The changes correctly update all import statements for jsontree across the affected files. The refactoring is well-executed and I have no concerns with the implementation.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@Isotr0py Isotr0py enabled auto-merge (squash) August 11, 2025 08:07
@vllm-bot vllm-bot merged commit 951b038 into vllm-project:main Aug 11, 2025
40 of 46 checks passed
@DarkLight1337 DarkLight1337 deleted the move-jsontree branch August 11, 2025 10:49
jingyu-ml pushed a commit to jingyu-ml/vllm that referenced this pull request Aug 11, 2025
@DarkLight1337
[Misc] Move jsontree to utils (vllm-project#22622)
0ddcc3a 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: jingyu <[email protected]>
aarnphm pushed a commit to aarnphm/vllm that referenced this pull request Aug 13, 2025
@DarkLight1337 @aarnphm
[Misc] Move jsontree to utils (vllm-project#22622)
e920f36 
Signed-off-by: DarkLight1337 <[email protected]>
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
@DarkLight1337 @paulpak58
[Misc] Move jsontree to utils (vllm-project#22622)
07573b6 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Paul Pak <[email protected]>
taneem-ibrahim pushed a commit to taneem-ibrahim/vllm that referenced this pull request Aug 14, 2025
@DarkLight1337 @taneem-ibrahim
[Misc] Move jsontree to utils (vllm-project#22622)
6cb2b9d 
Signed-off-by: DarkLight1337 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

@Isotr0py Isotr0py Isotr0py approved these changes

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

Assignees
No one assigned
Labels
multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarkLight1337 @Isotr0py @vllm-bot